Offset current time to previously scheduled date#96
Open
omochi wants to merge 1 commit intovapor:mainfrom
Open
Offset current time to previously scheduled date#96omochi wants to merge 1 commit intovapor:mainfrom
omochi wants to merge 1 commit intovapor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug #94 which I reported.
This is second try to fix it.
First one is #95, but it had some issues.
This patch apply minimum threshold to current time which is used to calculate next scheduled date.
This threshold is come from previously scheduled date.
Example:
First, serve booted at 12:00:32 and schedule first execution at 12:01:00.
Unfortunately, job started at 12:00:59.
But it carries expected scheduled date information which is 12:01:00.
So to calculate next scheduled date,
offset current time 12:00:59 up to 12:01:00.
Then next scheduled date will be 12:02:00.
It can avoid immediately double execution.
Test log:
(I added
now=to message to share this. Its not included in patch.)It keep to run only once at every minutes.
Please review again @gwynne .