touch: fix inotify compatibility by avoiding O_TRUNC#11052
Draft
sylvestre wants to merge 1 commit intouutils:mainfrom
Draft
touch: fix inotify compatibility by avoiding O_TRUNC#11052sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre wants to merge 1 commit intouutils:mainfrom
Conversation
Replace File::create() with OpenOptions::new().create_new(true) to avoid the O_TRUNC flag that interferes with inotify file change detection. The O_TRUNC flag in file creation was causing issues with applications like 0 A.D. that monitor configuration files for changes using inotify. The new implementation uses O_EXCL instead, which is safer and doesn't interfere with inotify event generation. closes: uutils#9812
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace File::create() with OpenOptions::new().create_new(true) to avoid the O_TRUNC flag that interferes with inotify file change detection.
The O_TRUNC flag in file creation was causing issues with applications like 0 A.D. that monitor configuration files for changes using inotify. The new implementation uses O_EXCL instead, which is safer and doesn't interfere with inotify event generation.
closes: #9812