Skip to content

Comments

numfmt: reduce malloc#11026

Closed
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:numfmt-malloc
Closed

numfmt: reduce malloc#11026
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:numfmt-malloc

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 19, 2026

numfmt_to_si_precision[10000] +2%
numfmt_to_si[10000] +1%
numfmt_from_si[10000] +1%
numfmt_round_modes[("up", 10000)] +1%
numfmt_round_modes[("towards-zero", 10000)] +1%
numfmt_round_modes[("down", 10000)] +1%
numfmt_large_numbers_si[10000] +1%
numfmt_padding[(10000, 50)] 0% 51.3 ms -> 51.1 ms
numfmt_to_iec[10000] 0% 35.4 ms -> 35.3 ms

@oech3 oech3 marked this pull request as ready for review February 19, 2026 14:51
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2026

Merging this PR will not alter performance

✅ 288 untouched benchmarks
⏩ 40 skipped benchmarks1


Comparing oech3:numfmt-malloc (ef0fca7) with main (6633ab8)

Open in CodSpeed

Footnotes

  1. 40 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/date/date-locale-hour is no longer failing!

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?

@xtqqczze
Copy link
Contributor

I noticed we can remove the buffer completely, opened #11051

@oech3 oech3 closed this Feb 22, 2026
@oech3 oech3 deleted the numfmt-malloc branch February 22, 2026 06:55
@oech3 oech3 restored the numfmt-malloc branch February 22, 2026 06:57
@oech3 oech3 reopened this Feb 22, 2026
@oech3 oech3 closed this Feb 22, 2026
@oech3 oech3 deleted the numfmt-malloc branch February 22, 2026 06:58
@oech3
Copy link
Contributor Author

oech3 commented Feb 22, 2026

OK to close this. Right?

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail/retry is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants