Improved message for outdated TPL and removed possibly confusing println#2666
Open
Improved message for outdated TPL and removed possibly confusing println#2666
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2666 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6680 6682 +2
=======================================
Files 795 795
Lines 65902 65902
Branches 9880 9880
=======================================
+ Hits 30714 30719 +5
+ Misses 32810 32801 -9
- Partials 2378 2382 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavyLandman
reviewed
Feb 19, 2026
| throw rascalTplVersionError(msg); | ||
| } | ||
| qualifiedModuleName = moduleId2moduleName(moduleId); | ||
| return <false, tmodel(modelName=qualifiedModuleName, messages=[error("Cannot read TPL for <qualifiedModuleName>", tplLoc)]), ms>; |
Member
There was a problem hiding this comment.
I think it shouldn't be reported on the tplLoc that is not a file a user can open in an IDE, it might be a related loc, but not the main loc.
Member
Author
There was a problem hiding this comment.
In principle, I agree, but we may not have anything else to point to: this can be a tpl file for which no source is available. I will ponder on other options ...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.