Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
- Coverage 46% 46% -1%
+ Complexity 6677 6670 -7
=======================================
Files 795 795
Lines 65899 65902 +3
Branches 9878 9880 +2
=======================================
- Hits 30709 30706 -3
- Misses 32806 32818 +12
+ Partials 2384 2378 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is a work in progress. Not urgent. Testing out a first streaming solution to see if it works and how fast it still is. We're keeping a shadow buffer of int[1024] offsets which maps character offsets (indices into the array) to their codepoint offset count. From that we can derive the start of buffer and positions for every character in the current buffer.
Note that unicode characters in comments are equally responsible for shifts in the offsets as unicode characters in string constants and names.
posindex into buffer compensated for surrogate pairsWhen the above is done, the origin locations and the error positions will be
correct in the presence of surrogate pairs.