Refactor InsightsCard types and add disabled insights detection#23
Merged
Theosakamg merged 3 commits intomasterfrom Nov 13, 2025
Merged
Refactor InsightsCard types and add disabled insights detection#23Theosakamg merged 3 commits intomasterfrom
Theosakamg merged 3 commits intomasterfrom
Conversation
- Replace all 'any' types with specific TypeScript interfaces - Add InsightValue, InsightDimensions, InsightDataItem, and InsightResponse types - Import Chart.js types (ChartData, ChartOptions, TooltipItem) for type safety - Add proper undefined checks to prevent "possibly undefined" errors - Add computed property to detect when insights are disabled - Show user-friendly message to contact support when insights are disabled 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type safety and user experience in the InsightsCard component by replacing loose any types with strict TypeScript interfaces and adding detection for disabled insights.
- Replaces
anytypes with specific TypeScript interfaces (InsightValue, InsightDimensions, InsightDataItem, InsightResponse) - Imports Chart.js types and adds proper undefined checks for type safety
- Adds a computed property to detect when insights are disabled and displays a user-friendly message
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
LGTM |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code