Skip to content

fix(System Devices): fix the link to the new boot parms page for VM options.#2540

Open
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:Feature-Add-GPU-SRIOV
Open

fix(System Devices): fix the link to the new boot parms page for VM options.#2540
SimonFair wants to merge 1 commit intounraid:masterfrom
SimonFair:Feature-Add-GPU-SRIOV

Conversation

@SimonFair
Copy link
Contributor

@SimonFair SimonFair commented Feb 6, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated a warning link to correctly direct to the Boot Parameters page.

@SimonFair SimonFair added the 7.3 label Feb 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

A refactoring change that extracts a hardcoded Boot Parameters URL into a named variable in SysDevs.php, improving code maintainability without altering functional behavior.

Changes

Cohort / File(s) Summary
Boot Parameters URL Refactoring
emhttp/plugins/dynamix/include/SysDevs.php
Introduced $bootParamsUrl variable to store the Boot Parameters page URL, replacing the hardcoded URL reference in the warning link display. No functional behavior change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A URL hops from hardcode to a variable free,
Cleaner paths for Boot Parameters we now see,
One small refactor, so tidy and neat,
Makes the codekeeper's life more complete!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: fixing a link to the boot parameters page for VM options in the System Devices section.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.02.06.1651
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2540/webgui-pr-2540.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/include/SysDevs.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2540, or run:

plugin remove webgui-pr-2540

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@SimonFair SimonFair changed the title fix(System Devices) fix the link to the new boot parms page for VM options. fix(System Devices): fix the link to the new boot parms page for VM options. Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant