denis: check for DCO with full name (not username)#300
Merged
charliemirabile merged 1 commit intomasterfrom Oct 6, 2025
Merged
denis: check for DCO with full name (not username)#300charliemirabile merged 1 commit intomasterfrom
charliemirabile merged 1 commit intomasterfrom
Conversation
theyoyojo
force-pushed
the
DCO_fix
branch
2 times, most recently
from
4984c41 to
bf48d27
Compare
Per the configuration provided to students by the containerfile served by orbit, the expected format of the signed-off-by line in student submissions is: Signed-off-by: $fullname <$username@$domain> Not: Signed-off-by: $username <$username@$domain> Pull the fullname from orbit.db in denis' check for the signed off by line and check for the correct format. Fixes #289 Signed-off-by: Joel Savitz <joel@underground.software>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the configuration provided to students by the containerfile served by orbit, the expected format of the signed-off-by line in student submissions is:
Not:
Pull the fullname from orbit.db in denis' check for the signed off by line and check for the correct format.
Fixes #289