Merged
Conversation
| def all | ||
| response = Request.new("customers/#{Ruber.customer_id}/deliveries").get | ||
|
|
||
| Collection.from_response(response, type: Delivery) |
Contributor
There was a problem hiding this comment.
No convendría directamente pasar el response.body dado que es lo único que se usa?
Member
Author
There was a problem hiding this comment.
Lo pensé y no veo razón para no hacerlo. Lo cambio.
| end | ||
|
|
||
| def initialize(data:, next_href:) | ||
| @data = data |
Contributor
There was a problem hiding this comment.
No tengo nada contra que se llame data, pero por ahí podría llamarse list o objects
Member
Author
There was a problem hiding this comment.
Los nombres son los que usa la API de Uber. Me pareció mejor mantenerlos.
bruno-costanzo
approved these changes
Feb 21, 2025
Co-authored-by: bruno costanzo <82187643+bruno-costanzo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users need to retrieve the list of deliveries from the Uber Direct API.
What
Collectionobject to represent a list of objects retrieved from the APIallmethod to DeliveryResource object