Merged
Conversation
Contributor
There was a problem hiding this comment.
no debería por defecto agregar el file cache al git ignore? (no digo al nuestro, sino al de cualquier app) y si no, al menos en el readme aclararlo.
Member
Author
There was a problem hiding this comment.
Sí, definitivamente. Al ser parametrizable no va a quedar otra que agregarlo en el Readme.
| end | ||
|
|
||
| def teardown | ||
| File.delete(Ruber.configuration.file_cache_path) if File.exist?(Ruber.configuration.file_cache_path) |
Contributor
There was a problem hiding this comment.
Suggested change
| File.delete(Ruber.configuration.file_cache_path) if File.exist?(Ruber.configuration.file_cache_path) | |
| @cache.clear |
Comment on lines
+44
to
+51
| def test_clear | ||
| @cache.write("key1", "value1") | ||
| @cache.write("key2", "value2") | ||
|
|
||
| @cache.clear | ||
| assert_nil @cache.read("key1") | ||
| assert_nil @cache.read("key2") | ||
| end |
Contributor
There was a problem hiding this comment.
Tengo una duda respecto a este test.
¿Qué pasa si volvés a escribir la caché después de hacer .clear? se vuelve a crear el archivo? tal vez se puede agregar al test ese caso para que quede claro.
Porque veo que el archivo se borra y no logro ver si se vuelve a crear.
Member
Author
There was a problem hiding this comment.
Sí, lo vuelve a crear. Ahí agrego un test más.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What