Skip to content

Conversation

@chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Nov 21, 2025

What

  • Update the go live instructions so the checklist has the same titles as the section headings
  • Rename the go live file to a more suitable name, that can be copied into each repository

Why

How this has been tested

  • I have tested locally
  • Testing not required

Reviewer Checklist

  • I have reviewed the PR and ensured no secret values are present

Signed-off-by: DBT pre-commit check
@chopkinsmade chopkinsmade force-pushed the feature/amend-the-go-live-checklist branch from b94b6a0 to 21caaf1 Compare November 21, 2025 15:25
@chopkinsmade chopkinsmade marked this pull request as ready for review November 21, 2025 15:26
Copy link
Contributor

@sumau sumau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chopkinsmade can you add a heading and intro to the SECURITY_CHECKLIST file? Something like:

Security Checklist

  • This checklist is designed to make it easier to improve the security posture of a GitHub repository.
  • It is mandatory for public repositories.
  • This checklist must be copied over to the root of the repository.
  • The repository steward is responsible for populating the checklist, or at least approving the related pull request.
  • Any feedback should be shared with the GitHub Security working group.

For more details about the security features please refer to the GitHub Standards repo.

I would also put the checklist at the top and the explanations below, or perhaps add the explanation below each bullet point as collapsed section: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections

Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
Signed-off-by: DBT pre-commit check
@chopkinsmade chopkinsmade requested a review from sumau November 25, 2025 16:53
@chopkinsmade chopkinsmade merged commit 9938431 into main Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants