Skip to content

Conversation

@bonlime
Copy link

@bonlime bonlime commented Jan 29, 2026

Fixes #511

Tests were vibed so if you think it's a little verbose, can shorten them

@MicaiahReid
Copy link
Member

Hmmm, I'm not sure about this.

When you first start a surfnet, the epoch info will come from the mainnet datasource. Now, we're clearing it out to zero.

I'm not sure what the expected behavior should be, one of these:

  1. Clear it out to zero like you have it
  2. When we first set the Epoch info after fetching from mainnet, cache "genesis info", and reset to that
  3. On reset, refetch from mainnet and have that new value be our epoch info

I'm of the opinion that we should go with option 2. Thoughts, @bonlime, @lgalabru?

@bonlime
Copy link
Author

bonlime commented Jan 30, 2026

that's a good point, I personally would go with option 3, since it would be closer to "full reset", I'll see if it's easy enough to do

@lgalabru
Copy link
Member

I'd go with option 3 when the surfnet has a datasource, and keep option 1 when the surfnet is offline

@MicaiahReid
Copy link
Member

Okay, sounds good. Let's go with option 3, @bonlime. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

surfnet_resetNetwork doesn't reset time

3 participants