feat/new admin JSON-RPC method surfpool_status that returns runtime metrics #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @dvansari65, thanks for the PR. To be honest, I'm not really seeing the value of this PR - are these metrics particularly useful to you for some reason? Most of them (slot, epoch, tx count, start time, etc) can already be retrieved by other RPCs - it seems like an unnecessary code maintenance burden to merge this. Also, it looks like this PR also contains commit for comparing snapshots to mainnet - it's a good practice to have every new PR be based from main so that merging one PR doesn't also require merging another. We do appreciate the contribution, but I'm not sure if this one is necessary - do you have a specific use-case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new admin JSON-RPC method surfpool_status that returns runtime metrics (slot, epoch, slot_index, transactions_count, transactions_processed, uptime_ms, and WS subscription counts).
purpose: Provides immediate operator/developer visibility into simnet health without shell access or log parsing.