{{{foo}}} when foo is a plain JS object should return JSON#231
Open
arekinath wants to merge 1 commit intotwitter:masterfrom
Open
{{{foo}}} when foo is a plain JS object should return JSON#231arekinath wants to merge 1 commit intotwitter:masterfrom
arekinath wants to merge 1 commit intotwitter:masterfrom
Conversation
|
Why is this not merged yet? The errors for the checks are all for the |
lib/template.js
Outdated
| hChars = /[&<>\"\']/; | ||
|
|
||
| function coerceToString(val) { | ||
| if (typeof (val) === 'object' && val.toString === Object.prototype.toString) |
|
Alex Wilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's not made clear in the spec, it seems most other implementations of mustache (and certainly the original Ruby one) spit out a nested object/hash/dict as some parseable form for their host language.
Example:
Currently in this case on Hogan.js, we just spit out
[object Object], which is not very useful:This patch amends
coerceToStringto return JSON when we're asked to output a nested plain JS object (ie, one without its owntoStringimplementation), so the output for the case above changes to"hi {\"bar\": 123, \"test\": \"abc\"}"