Allow implicit iteration over the root context element#220
Open
Mr0grog wants to merge 1 commit intotwitter:masterfrom
Open
Allow implicit iteration over the root context element#220Mr0grog wants to merge 1 commit intotwitter:masterfrom
Mr0grog wants to merge 1 commit intotwitter:masterfrom
Conversation
…#154, matches mustache.js behavior.
Author
|
Looks like the dependencies of some of the dependencies require Node 0.10+, so Travis is no longer able to complete a build on Node 0.6, which is what is specified in the |
Author
|
Anything I can do to help get this merged in? It’s been sitting for a week and a half and would be really great to have fixed. |
Author
|
Hi there, just checking in on this PR. Is anybody maintaining Hogan anymore? |
|
|
Author
|
Taking that as a sign of some more attention here, but is this PR still relevant? (I haven’t really been using Hogan in the last couple years and may not be up to speed.) Happy to sign the CLA if so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #154 and generally matches Mustache.js’s behavior. Since there’s no test for this in the Mustache spec (see mustache/spec#87), I’ve added a unit test for it.
It’d be really nice to have this added in—I recently dealt with a confusing moment when transitioning some Mustache templates that used this pattern to Hogan. If the bug is any indication, it’s tripped up others, too.