Open
Conversation
Owner
|
@alchen could you rebase these changes off latest master branch? |
ttezel
requested changes
May 31, 2018
Owner
ttezel
left a comment
There was a problem hiding this comment.
Could you rebase these changes off latest master so I can re-review?
Author
|
@ttezel Thanks for the interest of incorporating this. I am however no longer familiar with the changes that I wrote -- I quickly rebased everything and someone else might be able to pick up from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to use socks5 proxy for my Twitter requests, so I made some modifications to the module:
request.jsto encapsulaterequestwith relevant proxy configs.[mscdex/socksv5](https://github.com/mscdex/socksv5)to use request with socks5. There is only a handful of socks agents and this one seems to be still being maintained and also most up-to-date.req.on('response', ...because of request 2.65.0getPeerCertificate()always returnsnullon node 4.2.1, works on 0.12.7 nodejs/node#3545 (test cases was failing).The proxy option is enabled by adding something along this line into Twit config:
proxy: { host: '127.0.0.1', port: '1080' }I haven't had a chance to try HTTP proxies. I wonder how well they work with Twitter's https endpoints.