JsonRPC API: Add "input" as field for transaction input#6467
Open
simbadMarino wants to merge 3 commits intotronprotocol:developfrom
Open
JsonRPC API: Add "input" as field for transaction input#6467simbadMarino wants to merge 3 commits intotronprotocol:developfrom
simbadMarino wants to merge 3 commits intotronprotocol:developfrom
Conversation
Modified unit tests and parameters order
|
Good job! Maybe this pr can be added in the next version, along with some other related interface changes. The features for release 4.8.1 are already close to being ready, and I think it may be too late to include this in this version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds "input" field for transaction input while keeping "data" for legacy and compatibility.
Impacted JSON-RPC API methods:
Why are these changes required?
This PR has been tested by:
Follow up
Extra details