fix!: remove wasm references when wasm feature disabled#176
fix!: remove wasm references when wasm feature disabled#176XAMPPRocky wants to merge 1 commit intotrailbaseio:mainfrom
Conversation
9098a05 to
4d5a75a
Compare
|
@ignatz I've updated the PR with the latest branch, much smaller this time. I wanted to also add a check in CI for no default features, but it doesn't seem like the current ci actually builds or tests the code? I may be missing something but I don't see a place in the workflow where it runs cargo build or cargo test. |
|
Hi @XAMPPRocky, sorry for the very slow reply (back now). Testing more build-configs (combinatorial explosion aside) at CI time makes sense. Right now CI runs are 20+min would be great to not double.
It's a bit hidden. It is in the "test" workflow and the
Additionally all the client-tests have integration tests and run against a build of the As for the specific code changes, are they still needed? If I check out at head I can run Thanks 🙏 |
Thís is very rough cut to fix #174 it at least ensures that it no longer fails to compile.