Upgrade dependencies to the latest incompatible version #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform a first pass to eliminate a large number of dependencies and features from `rouille-multipart` that are not needed for `rouille`. The `rouille-multipart` version is bumped here since this represents an API break.
Eliminate `extern crate` that isn't needed in the 2021 edition. Also use this as an opportunity to apply std-external-crate import sorting. Some of the fuzzers and binary files got reformatted here, but they still don't build correctly.
`memchr` is already in the tree via `serde_json` and `buffer-redux`.
Clippy is now a standalone tool so this isn't needed.
Perform the incompatible upgrade for both `rouille` and `rouille-multipart`. The MSRV is still 1.63. This eliminates one version of `rand` from the graph.
The same version is now used in both `rouille` and `rouille-multipart`.
Brotli's MSRV is still 1.59.0.
cbandy
approved these changes
Dec 19, 2025
|
|
||
| # Only for Rocket example but dev-dependencies can't be optional | ||
| rocket = { version = "0.4", optional = true } | ||
| tiny_http = { version = "0.12", optional = true } |
There was a problem hiding this comment.
👍🏻 This resolves an indirect vulnerability identified by cargo-deny.
|
|
||
| [dev-dependencies] | ||
| env_logger = "0.5" | ||
| env_logger = "0.11" |
There was a problem hiding this comment.
👍🏻 This removes unsound behavior caused by an unmaintained dependency identified by cargo-deny.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
rand,tiny_http,env_logger, andbrotlito the latest across breaking versions.Based on top of #298 so there is less to do.