Vendor multipart, resolve FCWs, and prepare to republish #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squash merge the `multipart` repository into `rouille` so FCWs can be
resolved and unneeded features stripped out.
Original HEAD ref: f4fee608af ("Merge pull request tomaka#134 ...")
Apply Ondřej's patch from [1] to resolve future compatibility warnings in multipart, then update it further to resolve FCWs in all default features (the patch only resolved issues with the features that Rouille uses). Co-authored-by: Ondřej Hruška <ondra@ondrovo.com> [1]: tomaka#271
`buffer-redux` [1] is a maintained fork of `buf-redux` [2]. Switch to it in `multipart`. [1]: https://docs.rs/buffer-redux/latest/buffer_redux/ [2]: https://docs.rs/buf_redux/latest/buf_redux/
Contributor
Author
|
Version of #293 that squashes multipart's history |
tgross35
changed the title
tgross35
changed the title
In preparation for republishing this crate as a version that suit Rouille's needs, rename it.
bradfier
force-pushed
the
vendor-multipart
branch
from
ad8e38e to
683c73a
Compare
Collaborator
|
Cool - since if we republish |
Contributor
Author
|
By the way @bradfier - if you have any interest in any maintenance assistance, I would be happy to help out here. Nothing super active, but I'd be willing to at least get the nonbreaking modernization-type changes over the line into a minor release. You have been pretty responsive here so no worries if you have things covered. I just figured there is no harm in offering since I was planning to anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a resolution to #271, vendor the
multipartcrate https://github.com/abonander/multipart.The first commit adds an exact copy of
multipartfrom its current git repository.After the merge, the FCWs are fixed by switching
multipartfrombuf-reduxtobuffer-redux(the maintained fork) and applying @MightyPork's patch from #271, plus a few updates so it builds with default features.cargo fmtalso needs to be run (this should get a.git-blame-ignore-revsentry).Finally, the merged crate is renamed to
rouille-multipartso it can be published as a new crate. I think it would be good to strip out all features thatrouilledoes not need before publishing, but that is easiest done as a follow up.