feat(oracle): Added support for IN/OUT keywords in stored procedure parameters #6710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsanchez-xtillion
changed the title
rsanchez-xtillion
changed the title
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Hey @rsanchez-xtillion, thanks for taking a stab at this, but I'm not sure this is the right way to address this feature gap.
We generally handle these as ColumnConstraints. Have you tried introducing a constraint parser or something to avoid overriding and copying logic in Oracle?
Contributor
Author
|
Hey @georgesittas, I have not tried that approach but it makes more sense, I'll try doing it that way and push the changes when I'm ready |
rsanchez-xtillion
force-pushed
the
oracle-in-out-proc-params
branch
from
954f719 to
fb916a7
Compare
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Thanks @rsanchez-xtillion, looks better. A few more comments.
georgesittas
approved these changes
Jan 13, 2026
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
georgesittas
pushed a commit
that referenced
this pull request
Jan 13, 2026
…arameters (#6710) * Added support for Oracle IN/OUT in proc params * Made test more exhaustive * removed parse_column_def override in oracle and added column constraint parser instead * removed unused input arg from columndef expression * replaced replace(None) with pop() * fixed linter and formatting errors * save boolean as presence of IN/OUT keyword instead of keyword text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to parse optional IN/OUT keywords in stored procedure parameter declaration for Oracle. Example:
https://docs.oracle.com/en/database/other-databases/timesten/22.1/plsql-developer/examples-using-input-and-output-parameters-and-bind-variables.html#GUID-4B20426E-F93F-4835-88CB-6A79829A8D7F
Changes:
_parse_column_defmethod in Oracleinputproperty in theColumnDefclass