Miscellaneus #32
Open
Miscellaneus #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On C++ use std::cerr instead of std::cout. On C fputs does not append a new line (compared to puts which does). Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Do not just stop if the number reach zero. Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
All invalid characters in the string were interpreted as zero,
same as the equal ('=') padding.
For short strings treating padding as zero is fine ad the HMAC
algorithm pad the secret with zeroes if it fit into the
block. However if it does not fit the computation get wrong.
If the BASE32 secret is pretty large (104 characters for SHA1),
the key is replaced by an hashed version of it.
So, to make an example if the secret is up to 103 "A" characters
the binary key will be the same but adding any more "A" will cause the
key to change (and so the tokens).
This requires us to pass a key that is not multiple of 5 bytes,
so the implementation of otp_byte_secret() was changed to satisfy
this.
While at it catch and report invalid characters.
OTP_DEFAULT_BASE32_OFFSETS array was moved to C file, no reasons
to expose it.
Padding "=" characters are stripped at the beginning, allowing
to pass them or not, as most implementations are allowing this.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set. First 2 are more or less easy. The third is more complicated, see the commit message.