DOCS-2828: Fix error in Istio ambient mode docs #2489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
PTAL @radixo |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects technical inaccuracies in the Istio ambient mode documentation across multiple product versions. The documentation incorrectly stated that Istio ambient mode labels could be applied to services, when they actually only work with namespaces and pods.
Changes:
- Updated references from "services" to "pods" in deployment instructions and removal procedures
- Changed kubectl commands from
kubectl label servicetokubectl label pod - Updated terminology from "services" to "workloads" in conceptual descriptions
- Applied fixes across three product flavors (Calico Enterprise v3.22-2, v3.23-1, current; Calico Cloud current)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| calico-enterprise_versioned_docs/version-3.23-1/compliance/istio/deploy-istio-ambient.mdx | Corrected service→pod references in ambient mode labeling instructions and removal commands for version 3.23-1 |
| calico-enterprise_versioned_docs/version-3.23-1/compliance/istio/about-istio-ambient.mdx | Updated terminology from "services" to "workloads" for version 3.23-1 overview |
| calico-enterprise_versioned_docs/version-3.22-2/compliance/istio/deploy-istio-ambient.mdx | Corrected service→pod references in ambient mode labeling instructions and removal commands for version 3.22-2 |
| calico-enterprise_versioned_docs/version-3.22-2/compliance/istio/about-istio-ambient.mdx | Updated terminology from "services" to "workloads" for version 3.22-2 overview |
| calico-enterprise/compliance/istio/deploy-istio-ambient.mdx | Corrected service→pod references in ambient mode labeling instructions and removal commands for current version |
| calico-enterprise/compliance/istio/about-istio-ambient.mdx | Updated terminology from "services" to "workloads" for current version overview |
| calico-cloud/compliance/istio/deploy-istio-ambient.mdx | Corrected service→pod references in ambient mode labeling instructions and removal commands |
| calico-cloud/compliance/istio/about-istio-ambient.mdx | Updated terminology from "services" to "workloads" for overview |
calico-enterprise_versioned_docs/version-3.22-2/compliance/istio/deploy-istio-ambient.mdx
Outdated
Show resolved
Hide resolved
calico-enterprise_versioned_docs/version-3.22-2/compliance/istio/deploy-istio-ambient.mdx
Outdated
Show resolved
Hide resolved
| If you want to remove Istio, first remove the labels you applied to pods and namespaces. | ||
| When that's done, you can delete the `Istio` custom resource. | ||
|
|
||
| 1. Remove the label from namespaces and services by running the following commands: |
There was a problem hiding this comment.
This sentence still references "services" when it should reference "pods" to be consistent with the corrected commands below. This should read "Remove the label from namespaces and pods by running the following commands:" to accurately describe what the kubectl commands on lines 112-113 are doing.
Suggested change
| 1. Remove the label from namespaces and services by running the following commands: | |
| 1. Remove the label from namespaces and pods by running the following commands: |
calico-enterprise_versioned_docs/version-3.23-1/compliance/istio/deploy-istio-ambient.mdx
Outdated
Show resolved
Hide resolved
calico-enterprise_versioned_docs/version-3.23-1/compliance/istio/deploy-istio-ambient.mdx
Outdated
Show resolved
Hide resolved
electricjesus
approved these changes
Jan 28, 2026
The docs for Istio ambient mode mistakenly described labelling namespaces and services to create the mesh. These labels work only for namespaces and pods, not services. DOCS-2828
ctauchen
force-pushed
the
docs-2828-isto-service-bug
branch
from
75a9804 to
7b93ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for Istio ambient mode mistakenly described labelling
namespaces and services to create the mesh. These labels work
only for namespaces and pods, not services.
DOCS-2828
Product Version(s):
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: