Fixed doc comments of logger, and added type hints where applicable.#16
Open
boenrobot wants to merge 1 commit intothruway:masterfrom
Open
Fixed doc comments of logger, and added type hints where applicable.#16boenrobot wants to merge 1 commit intothruway:masterfrom
boenrobot wants to merge 1 commit intothruway:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a half related note... I see the latest commit also added PHP be ">7.1"... Shouldn't this be ">=7.1"? Or If the intention is "at least 7.2", maybe make that ">=7.2"? Also, probably good to update the readme too.
This PR only updates the type hints to PHP 7.1 levels, not 7.2 levels. In particular, 7.2 introduces "object" as a valid type hint, but I have not added it, in case the intent was actually ">=7.1".