Conversation
To qa/release/4.0.0
The decoder was not correctly handling temperatures below 0°C because it used unsigned integer parsing instead of handling signed values with two's complement representation. Changes: - Added parseTemperature() function to properly handle signed 16-bit values - Updated current temperature parsing to use new function - Fixed historical temperature data parsing (also corrected byte offset bug) - Added test cases with -5.2°C to verify negative temperature handling Applies to all network server implementations: - ChirpStack - HTTP - LORIOT - ThingsStackCommunity - ThingsStackIndustries Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
… into fix/em320-th-4.0
Enhanced the validation error message to display both expected and actual output when converter validation fails. This makes debugging converter issues much easier by showing exactly what the difference is. Changes: - Added JSON-formatted output of expected result - Added JSON-formatted output of actual result - Both outputs are pretty-printed with 2-space indentation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed two issues with the EM320-TH negative temperature tests: 1. Corrected timestamps in result_01.json files - Timestamps were calculated incorrectly (off by 3000 seconds) - Updated all 5 result files with correct timestamps 2. Fixed validator to properly parse and display JSON output - Parse JSON output before comparison and display - This fixes the issue where actual output was shown as a quoted string Changes: - Updated timestamps in all result_01.json files (ChirpStack, HTTP, LORIOT, ThingsStackCommunity, ThingsStackIndustries) - Modified validator to parse output once and reuse for comparison and display Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The LORIOT format includes timestamp directly in the payload. Corrected from 1703329530547 to 1703326530547. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
[4.0+] Fix EM320-TH decoder to handle negative temperatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.