-
Notifications
You must be signed in to change notification settings - Fork 0
ci: setup tests #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setup tests #44
Conversation
106b5b3 to
9f35f48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR sets up GitHub Actions CI workflows to replace the deprecated Prow CI system. The changes include creating automated testing and building pipelines, along with example integration testing.
- Added main CI workflow with Go testing, building, and vulnerability scanning
- Added example CI workflow for integration testing with Node.js dependencies
- Updated test expectations to use relative paths instead of full GitHub module paths
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/main.yml |
Main CI pipeline with Go tests, build, and security checks |
.github/workflows/example.yml |
Example integration testing with Go and Node.js setup |
trace/trace_test.go |
Updated expected log paths to be relative for CI compatibility |
| run: | | ||
| cd example | ||
| make rungo & | ||
| make runjs |
Copilot
AI
Aug 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running make rungo in the background without proper process management could leave orphaned processes. Consider adding a cleanup mechanism or using a more robust way to manage the background process lifecycle.
| make runjs | |
| make rungo & | |
| RUNGO_PID=$! | |
| make runjs | |
| kill $RUNGO_PID |
65c22bb to
790db49
Compare
I don’t plan to spend more time on this:
|
Type of change
Description
Related issues
#43.
Notes for reviewer
Deprecated the Prow CI after this PR is merged.