Skip to content

Conversation

@junhuif
Copy link
Member

@junhuif junhuif commented Jun 27, 2025

Type of change

  • configuration
  • test

Description

  • Setup CI on GitHub Actions:
    • Run test, build.
    • Run example.

Related issues

#43.

Notes for reviewer

Deprecated the Prow CI after this PR is merged.

@junhuif junhuif self-assigned this Jun 27, 2025
@junhuif junhuif requested a review from Copilot June 27, 2025 04:37
@junhuif junhuif changed the base branch from master to chore/bump-go-version June 27, 2025 04:37
@junhuif junhuif requested review from bodhi, geckofu, lifenod and tnclong June 27, 2025 04:37

This comment was marked as outdated.

@junhuif junhuif changed the base branch from chore/bump-go-version to master August 7, 2025 08:11
@junhuif junhuif force-pushed the ci/setup-tests branch 3 times, most recently from 106b5b3 to 9f35f48 Compare August 7, 2025 10:09
@junhuif junhuif requested a review from Copilot August 7, 2025 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up GitHub Actions CI workflows to replace the deprecated Prow CI system. The changes include creating automated testing and building pipelines, along with example integration testing.

  • Added main CI workflow with Go testing, building, and vulnerability scanning
  • Added example CI workflow for integration testing with Node.js dependencies
  • Updated test expectations to use relative paths instead of full GitHub module paths

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/main.yml Main CI pipeline with Go tests, build, and security checks
.github/workflows/example.yml Example integration testing with Go and Node.js setup
trace/trace_test.go Updated expected log paths to be relative for CI compatibility

run: |
cd example
make rungo &
make runjs
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running make rungo in the background without proper process management could leave orphaned processes. Consider adding a cleanup mechanism or using a more robust way to manage the background process lifecycle.

Suggested change
make runjs
make rungo &
RUNGO_PID=$!
make runjs
kill $RUNGO_PID

Copilot uses AI. Check for mistakes.
@junhuif junhuif force-pushed the ci/setup-tests branch 2 times, most recently from 65c22bb to 790db49 Compare August 8, 2025 08:30
@junhuif junhuif removed the request for review from bodhi August 11, 2025 01:24
@junhuif
Copy link
Member Author

junhuif commented Aug 11, 2025

X-ref: https://theplanttokyo.atlassian.net/browse/MWMOP-4365?focusedCommentId=432207

I don’t plan to spend more time on this:

  • Migrating CI from Prow to GitHub Actions is not necessary.
  • Prottp currently depends on multiple Protobuf versions, causing unstable CI results.
  • Fixing the multiple Protobuf dependency issue in Prottp would involve updating multiple repos, such as theplant/validator and other apps that depend on Prottp.

@junhuif junhuif closed this Aug 11, 2025
@junhuif junhuif deleted the ci/setup-tests branch August 11, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants