Conversation
This feature allows tasks to be marked with `continueOnError: true`. If such a task fails, dependent tasks will execute as if the dependency succeeded, while the task itself is still marked as failed. Implementation details: - Added `continueOnError` property to `TaskStep` interface. - Updated `TaskStateManager` to store task definitions and check `continueOnError` on failure. - Added comprehensive tests in `tests/continueOnError.test.ts`. - Archived the spec in `openspec/changes/archive/2026-02-18-feat-continue-on-error`. Co-authored-by: thalesraymond <32554150+thalesraymond@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @thalesraymond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the task execution workflow by adding a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The implementation of the continueOnError feature is correct and follows the proposal. It allows workflows to proceed even when non-critical tasks fail, provided they are explicitly marked. I have suggested a few improvements to remove redundant state in TaskStateManager, as the TaskStep object already contains the necessary metadata, making the additional taskDefinitions map unnecessary.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Updated comments in TaskStateManager.ts to better explain the behavior of the continueOnError flag logic, as requested in PR review. Co-authored-by: thalesraymond <32554150+thalesraymond@users.noreply.github.com>
|
1 participant
Implemented the
continueOnErrorfeature as per the OpenSpec proposal. This includes updates toTaskStep,TaskStateManager, and new tests. Verified with build, tests, and lint.PR created automatically by Jules for task 2600073256240428257 started by @thalesraymond