Open
Conversation
Allow running on mac/mps where vllm isn't used
Allow to run other searchers without java installed
Collaborator
|
Hello! Thank you for your interest and contribution to BrowseComp-Plus! Generally the device compatibility and lazy imports look good to me. However, may I ask if the same installation instructions in README would still default to install linux-dependent / CUDA packages on a linux machine, given the changes in pyproject.toml? If not, what should we update in the the instructions? Thanks! |
Author
|
@wu-ming233 - thanks for your response. You are right, I updated the uv.lock and updated the readme to include updated instructions and to specifically mention which components require a gpu. |
5494524 to
0c929eb
Compare
This reverts commit e425922.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several modifications for improved cross-platform support and external integration: