Skip to content

Fix ActivityAlreadyStartedError message #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuandrew merged 3 commits into from
Mar 2, 2026
Merged

Fix ActivityAlreadyStartedError message #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c34168
Add failing test for ActivityAlreadyStartedError wrong message
dandavison Feb 28, 2026
3f852fe
Fix
dandavison Feb 28, 2026
48832d6
rm repro script
dandavison Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions temporalio/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ class ActivityAlreadyStartedError(FailureError):
def __init__(
self, activity_id: str, activity_type: str, *, run_id: str | None = None
) -> None:
"""Initialize a workflow already started error."""
super().__init__("Workflow execution already started")
"""Initialize an activity already started error."""
super().__init__("Activity execution already started")
self.activity_id = activity_id
self.activity_type = activity_type
self.run_id = run_id
Expand Down
3 changes: 3 additions & 0 deletions tests/test_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,9 @@ async def test_id_conflict_policy_fail(client: Client, env: WorkflowEnvironment)
id_conflict_policy=ActivityIDConflictPolicy.FAIL,
)
assert err.value.activity_id == activity_id
assert "Activity" in str(
err.value
), f"Expected 'Activity' in error message, got: {err.value}"


async def test_id_conflict_policy_use_existing(
Expand Down