-
-
Notifications
You must be signed in to change notification settings - Fork 144
feat(auth): implement Twitch OAuth provider wrapper #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
…neration to use the enum name instead of class
|
That one was an utter nightmare to chase down, I had to xdebug and step in the code. Turns out, changing the installer to handle outputting 'Twitch' instead of 'TwitchHelix' also broke the null -> 'generic' default case, so I had to put 'Generic' specifically in The tests pass locally. But I can see it complaining about rate-limiting from docker in the integration test on GH actions so that's fun. |
innocenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking time to fix the CI 🙏 just a minor change before merging
Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
No worries, makes sense, so have committed both. Another test run is on it's way! |
(Replaces broken PR 1899...)
Prior to this PR, composer.json included library depotwarehouse/oauth2-twitch for OAuth with Twitch, but it did not have a wrapper.
However this library uses the Twitch Kraken API, which is no longer available, as of 2022 (source) - PHPLeague also need to deprecate the package, I'll let them know to remove it.