Merged
Conversation
src/libcmis/atom-document.cxx:303:15: style: Variable 'link' can be declared as pointer to const [constVariablePointer] src/libcmis/atom-document.cxx:397:15: style: Variable 'link' can be declared as pointer to const [constVariablePointer] src/libcmis/atom-folder.cxx:63:15: style: Variable 'childrenLink' can be declared as pointer to const [constVariablePointer] src/libcmis/atom-folder.cxx:266:15: style: Variable 'treeLink' can be declared as pointer to const [constVariablePointer] src/libcmis/atom-object.cxx:260:15: style: Variable 'destChildrenLink' can be declared as pointer to const [constVariablePointer] src/libcmis/atom-object.cxx:314:15: style: Variable 'selfLink' can be declared as pointer to const [constVariablePointer] src/libcmis/ws-object-type.cxx:69:25: style: Variable 'other' can be declared as pointer to const [constVariablePointer] src/libcmis/ws-object.cxx:108:21: style: Variable 'other' can be declared as pointer to const [constVariablePointer]
caolanm
approved these changes
Mar 3, 2024
dtardon
reviewed
Mar 4, 2024
| { | ||
| libcmis::ObjectTypePtr type = m_session->getType( m_id ); | ||
| WSObjectType* const other = dynamic_cast< WSObjectType* >( type.get( ) ); | ||
| const WSObjectType* const other = dynamic_cast< WSObjectType* >( type.get( ) ); |
Contributor
There was a problem hiding this comment.
The type in the dynamic_cast should be updated too. (Even better: change just the type in the cast and use const auto for the variable decl.)
dtardon
reviewed
Mar 4, 2024
| { | ||
| libcmis::ObjectPtr object = m_session->getObject( getId( ) ); | ||
| WSObject* const other = dynamic_cast< WSObject* >( object.get( ) ); | ||
| const WSObject* const other = dynamic_cast< WSObject* >( object.get( ) ); |
Contributor
Author
There was a problem hiding this comment.
See previous comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/libcmis/atom-document.cxx:303:15: style: Variable 'link' can be declared as pointer to const [constVariablePointer]
src/libcmis/atom-document.cxx:397:15: style: Variable 'link' can be declared as pointer to const [constVariablePointer]
src/libcmis/atom-folder.cxx:63:15: style: Variable 'childrenLink' can be declared as pointer to const [constVariablePointer]
src/libcmis/atom-folder.cxx:266:15: style: Variable 'treeLink' can be declared as pointer to const [constVariablePointer]
src/libcmis/atom-object.cxx:260:15: style: Variable 'destChildrenLink' can be declared as pointer to const [constVariablePointer]
src/libcmis/atom-object.cxx:314:15: style: Variable 'selfLink' can be declared as pointer to const [constVariablePointer]
src/libcmis/ws-object-type.cxx:69:25: style: Variable 'other' can be declared as pointer to const [constVariablePointer]
src/libcmis/ws-object.cxx:108:21: style: Variable 'other' can be declared as pointer to const [constVariablePointer]