Open
Conversation
Author
Rollback Files For Sweep
|
Author
Apply Sweep Rules to your PR?
|
Author
Apply Sweep Rules to your PR?
|
Owner
|
Can you also add another function called "addComplexNumbers" that adds two Complex numbers and returns their sum ? |
Author
🚀 Wrote ChangesDone. |
Owner
|
Can you add a unit test for addComplexNumbers ? Add it in a file called add_test.go and put that file in the same directory. |
Author
🚀 Wrote ChangesDone. |
taherv
requested changes
Oct 15, 2023
| a, b complex128 | ||
| expected complex128 | ||
| }{ | ||
| {"add zero", 0, 0, 0}, |
Owner
There was a problem hiding this comment.
Add another test scenario here, for large numbers (e.g. 9 digit imaginary component of the complex number).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new file
add.goto the repository, which contains a function to add two numbers and return the sum. The function is implemented in Go and follows the naming conventionaddNumbers.Summary of Changes
add.goin the root directory of the repository.package mainat the top of the file.addNumbersthat takes two integer parameters and returns their sum.Please review and merge this PR. Thank you!
Fixes #7.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: