Skip to content

Conversation

@stack72
Copy link
Contributor

@stack72 stack72 commented Jan 15, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link

There are luminork endpoint changes on this branch that do not appear to have associated tests. Please ensure you add or update tests under bin/si-luminork-api-tests/tests/ to satisfy this warning.

@stack72 stack72 force-pushed the luminork-get-schema-upgrades branch from 8d4e010 to da7c660 Compare January 16, 2026 00:11
@stack72 stack72 requested a review from nickgerace January 16, 2026 00:11
@stack72 stack72 marked this pull request as ready for review January 16, 2026 00:11
#[schema(value_type = bool)]
pub installed: bool,
#[schema(value_type = Option<bool>, example = true)]
pub upgrade_available: Option<bool>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just a bool?

/// the installed module hash with the latest cached module hash.
///
/// Returns:
/// - `None` if the schema is not installed (no comparison possible)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Part of me wonders if this will be clear in the response via the API to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants