Split out summary generator code with minor improvements #8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
github-actions
bot
added
A-si-settings
|
There are luminork endpoint changes on this branch that do not appear to have associated tests. Please ensure you add or update tests under |
nickgerace
force-pushed
the
nick/fceb66f
branch
from
62f8b5b to
b837bca
Compare
nickgerace
force-pushed
the
nick/fceb66f
branch
4 times, most recently
from
7831320 to
579446b
Compare
nickgerace
changed the title
nickgerace
force-pushed
the
nick/fceb66f
branch
from
579446b to
befedc0
Compare
nickgerace
commented
Jan 14, 2026
Comment on lines
+13
to
+14
| // TODO(nick): enable this and add docs. | ||
| // missing_docs, |
Contributor
Author
There was a problem hiding this comment.
Not important for this PR
| #[instrument(level = "info", skip(ctx))] | ||
| #[instrument( | ||
| name = "diagram.assemble", | ||
| level = "info", |
Contributor
Author
There was a problem hiding this comment.
Chopped down all spans in this file into one: used fields instead and renamed to be more clear
Comment on lines
+167
to
+174
| let (component_details, next_cursor) = list_components_inner( | ||
| ctx, | ||
| limit, | ||
| cursor, | ||
| include_codegen, | ||
| maybe_summary_generator_config, | ||
| ) | ||
| .await?; |
Contributor
Author
There was a problem hiding this comment.
The "inner" function contains all the logic without having to content with route-relevant semantics like extractors and return types
| // Get all component IDs. This ensures that we do not access CAS. Then, sort for consistent | ||
| // pagination. | ||
| let mut all_component_ids = Component::list_ids(ctx).await?; | ||
| all_component_ids.sort(); |
Contributor
Author
There was a problem hiding this comment.
The sort is functionally the same
| schema_name, | ||
| codegen: None, | ||
| for paginated_component_id in paginated_component_ids.iter().copied() { | ||
| component_details_vec.push(ComponentDetailsV1 { |
Contributor
Author
There was a problem hiding this comment.
No longer a mutable type
| // Build graph summary for the components. Drop the HEAD context from scope as soon as we | ||
| // no longer need it. | ||
| let graph_summaries = { | ||
| let head_ctx = ctx.clone_with_head().await?; |
Contributor
Author
There was a problem hiding this comment.
One head context for the entire lifespan of the route
Comment on lines
+440
to
+450
| #[derive(Debug)] | ||
| struct SummaryGeneratorConfig { | ||
| include_action_functions: bool, | ||
| include_diff_status: bool, | ||
| include_execution_history: bool, | ||
| include_management_functions: bool, | ||
| include_manages: bool, | ||
| include_qualification_functions: bool, | ||
| include_resource_info: bool, | ||
| include_subscriptions: bool, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Debug dump the config as needed. Maybe we should record this in a span, but I wanted to keep tracing span count impact minimal (this PR reduces the total number of spans).
nickgerace
force-pushed
the
nick/fceb66f
branch
from
befedc0 to
f768a3b
Compare
nickgerace
changed the title
nickgerace
force-pushed
the
nick/fceb66f
branch
from
f768a3b to
8064f1e
Compare
johnrwatson
reviewed
Jan 15, 2026
This change splits out the summary generator code and provides minor improvements. The improvements include the following: - Not fetching all components by only listing their IDs - Adding instrumentation and span recordings of durations of long-running tasks to both quantify how long the code is truly taking as well as decrese and clean up the total number of spans - Caching "head_ctx" for fewer queries and more consistent HEAD state - Decrease the number of diagram assembly spans, but record the duration of inner parts There is now an integration test for the graph lab code too. Signed-off-by: Nick Gerace <nick@systeminit.com>
nickgerace
force-pushed
the
nick/fceb66f
branch
from
8064f1e to
83ed38d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change splits out the summary generator code and provides minor improvements. The improvements include the following:
There is now an integration test for the component summary generator too.
Testing and Docs
includeAllfieldFuture Potential Work
Screenshots
Swagger UI query used with
includeAlland 85 components:Overview of traces in Jaeger corresponding to these calls:
The two new spans with their fields populated to help determine performance bottlenecks (note: the spans now have different names):