Conversation
bambruysk
approved these changes
Jan 18, 2023
bambruysk
left a comment
bambruysk
left a comment
There was a problem hiding this comment.
Хороший код в целом. Мелкие замечания нужно поправвить
| } | ||
|
|
||
| func (c URLConnection) Close(db *sqlx.DB) { | ||
| defer func(db *sqlx.DB) { |
| return bindUser(rows) | ||
| } | ||
|
|
||
| func (d *Database) execute(ctx context.Context, filename string, model interface{}) (*sqlx.Rows, error) { |
There was a problem hiding this comment.
Для исполнения sql запросов из файла удобнее использовать https://pkg.go.dev/embed - сразу читает файл в строку на этапе компиляции
| } | ||
| close(errs) | ||
| }() | ||
| wg.Wait() |
There was a problem hiding this comment.
Зачем здесь горутинв если мы ждем ее завершения сразу после запуска?
| @@ -0,0 +1,36 @@ | |||
| CREATE TYPE detail AS ENUM ('TEXT', 'BLOB', 'CARD', 'DETAIL'); | |||
|
|
|||
| CREATE TABLE records ( | |||
| } | ||
|
|
||
| func (r *Record) Validate() error { | ||
| return validator.New().Struct(r) |
There was a problem hiding this comment.
рекомендуется валидатор делать синглтоном или глобальноу переменной в целях производительности
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.