[Validator] Fix NotBlank validator to treat whitespace-only strings as blank#41
Open
lionelkimbs wants to merge 1 commit intosymfony:7.0from
Open
[Validator] Fix NotBlank validator to treat whitespace-only strings as blank#41lionelkimbs wants to merge 1 commit intosymfony:7.0from
lionelkimbs wants to merge 1 commit intosymfony:7.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The NotBlank validator previously failed to recognize strings consisting solely of whitespace characters (e.g., "
Solution:
This PR updates the NotBlank validator's logic to treat strings that contain only whitespace characters as blank.
Key Changes:
Updated the validation logic in the NotBlankValidator class to trim value if type is string, then proceed to current checking.
Testing:
Comprehensive unit tests have been added to verify the correct behavior of the NotBlank validator with whitespace-only strings. All existing tests have been run to ensure that this change does not introduce regressions in other parts of the application.