Skip to content

fix randomize settings#38

Open
telephon wants to merge 1 commit intomainfrom
fix-randomize-settings
Open

fix randomize settings#38
telephon wants to merge 1 commit intomainfrom
fix-randomize-settings

Conversation

@telephon
Copy link
Contributor

@telephon telephon commented Sep 1, 2025

This has been around for a long time, @adcxyz could you check?

@adcxyz
Copy link
Contributor

adcxyz commented Sep 2, 2025

As is, this seems to revert a lot of newer code - maybe it needs to be rebased first?
I am not sure what the specific section that is supposed to fix randomizing.
There is a newer fix to one conceptual error in setRand, which this PR reverts
(this one keeps arrays as param values intact):

	-	proxy.set(*this.randSet(rand, startSet, except, seed).flatten(1));
	+      proxy.set(*this.randSet(rand, startSet, except, seed).flat);	

@adcxyz
Copy link
Contributor

adcxyz commented Sep 3, 2025

I looked again, and I don't find any functional improvement here,
but lots of unintended reverts.
@telephon, if you like, please rebase and check if you see any useful changes remaining.
If not, we can just drop this one.

@telephon
Copy link
Contributor Author

telephon commented Sep 8, 2025

I don't see – onto what branch you want me to rebase? It is on main already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants