Conversation
|
@Kanavpreet-Singh is attempting to deploy a commit to the Suman Kunwar's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
There was a problem hiding this comment.
Pull Request Overview
Adds a new beginner project page describing and embedding a Simon Says memory game, including features, concepts practiced, and a live demo.
- Introduces a new project doc with description, features, and bonus challenges
- Embeds a live demo via an iframe (CodeSandbox)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <iframe src="https://codesandbox.io/p/sandbox/frosty-nobel-849xrz" | ||
| style="width:100%; height: 500px; border:0; border-radius: 4px; overflow:hidden;" | ||
| title="simon-says-game" | ||
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" |
There was a problem hiding this comment.
The iframe src points to a CodeSandbox editor URL (/p/sandbox/...) which is typically blocked from embedding; use the embed endpoint instead. Replace with https://codesandbox.io/embed/frosty-nobel-849xrz (optionally add query params like ?fontsize=14&hidenavigation=1&theme=light).
|
|
||
| ## Live Demo | ||
|
|
||
| <div align="center"> |
There was a problem hiding this comment.
[nitpick] The align attribute is obsolete in HTML5. Prefer a style-based approach, e.g., <div style="text-align:center"> or a CSS class.
| <div align="center"> | |
| <div style="text-align:center;"> |
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" |
There was a problem hiding this comment.
The iframe permissions and sandbox flags are overly broad for a simple game embed; apply the principle of least privilege. Suggest narrowing to only what’s needed, e.g., allow="fullscreen" and sandbox="allow-scripts allow-same-origin".
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | |
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | |
| allow="fullscreen" | |
| sandbox="allow-scripts allow-same-origin" |
| <div align="center"> | ||
| <iframe src="https://codesandbox.io/p/sandbox/frosty-nobel-849xrz" | ||
| style="width:100%; height: 500px; border:0; border-radius: 4px; overflow:hidden;" | ||
| title="simon-says-game" |
There was a problem hiding this comment.
Add loading="lazy" to the iframe to defer loading the demo until it scrolls into view, improving page load performance.
| title="simon-says-game" | |
| title="simon-says-game" loading="lazy" |
| title="simon-says-game" | ||
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| ></iframe> |
There was a problem hiding this comment.
Provide a fallback link for users/browsers that block iframes. Add a link just below the iframe, e.g.,
<a href="https://codesandbox.io/s/frosty-nobel-849xrz\" target="_blank" rel="noopener noreferrer">Open live demo on CodeSandbox
.| ></iframe> | |
| ></iframe> | |
| <p><a href="https://codesandbox.io/s/frosty-nobel-849xrz" target="_blank" rel="noopener noreferrer">Open live demo on CodeSandbox</a></p> |
|
@Kanavpreet-Singh Is it possible to put the whole source code inside a folder under examples folder like others? |
|
added @sumn2u |
2 participants
worked on issue #352 under hacktoberfest 2025
Screenshot:
