Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a live demo section to the image search beginner project documentation, providing users with an interactive CodeSandbox embed to see the application in action.
- Added a Live Demo section with an embedded CodeSandbox iframe
- Configured the iframe with appropriate sandbox permissions and styling
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| ## Live Demo | ||
| <div align="center"> | ||
| <iframe src="https://codesandbox.io/embed/9xkmxr?view=preview&module=%2Fstyles.css" |
There was a problem hiding this comment.
The CodeSandbox URL appears to be incomplete or invalid. The embed ID '9xkmxr' seems too short for a typical CodeSandbox URL format, which usually contains longer alphanumeric identifiers.
| <iframe src="https://codesandbox.io/embed/9xkmxr?view=preview&module=%2Fstyles.css" | |
| <iframe src="https://codesandbox.io/embed/new?view=preview&module=%2Fstyles.css" |
| <iframe src="https://codesandbox.io/embed/9xkmxr?view=preview&module=%2Fstyles.css" | ||
| style="width:100%; height: 500px; border:0; border-radius: 4px; overflow:hidden;" | ||
| title="image-search" | ||
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" |
There was a problem hiding this comment.
The iframe allows excessive permissions that are unnecessary for an image search demo. Consider limiting to only required permissions like 'allow-scripts allow-same-origin' to follow the principle of least privilege.
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | |
| allow="allow-scripts; allow-same-origin" |
1 participant
Image search demo application added