Fix Windows Compilation by Adding Missing winapi Dependency#3
Merged
sukeesh merged 1 commit intosukeesh:mainfrom Mar 4, 2025
Merged
Fix Windows Compilation by Adding Missing winapi Dependency#3sukeesh merged 1 commit intosukeesh:mainfrom
sukeesh merged 1 commit intosukeesh:mainfrom
Conversation
…inapi` with feature `winuser` because, the function `fn set_app_icon_windows(icon_data: &IconData) -> AppIconStatus` in the app_icon.rs file in eframe native depends on `winapi::um::winuser` as an external crate which is needed at compile time
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compilation issue on Windows by adding the
winapicrate with thewinuserfeature.Issue
fn set_app_icon_windows(icon_data: &IconData) -> AppIconStatusinapp_icon.rs(withineframenative) depends onwinapi::um::winuser.winapiwas missing as a dependency, causing the build to fail on Windows.Solution
winapiwith thewinuserfeature toCargo.tomlto ensure the necessary symbols are available at compile time.Cargo.lockaccordingly.