Skip to content

Conversation

@pan103769
Copy link

@pan103769 pan103769 commented Jan 9, 2026

This PR finalizes and cleans up the Sugar Activities: Complete Guide documentation by consolidating and normalizing the content into a single, well-structured Markdown document.

Changes included:

Consolidated the full “Make Your Own Sugar Activities” guide into docs/Sugar_Activities.md

Removed UI artifacts and copy-paste noise from the original source

Normalized Markdown structure (headings, code blocks, spacing)

Preserved all original content exactly (no technical or textual changes)

Ensured long code examples remain intact and unmodified

issue:#21

@pan103769
Copy link
Author

Hey @quozl, I’ve added examples from the official FLOSS Manuals and filled in some missing content. Please have a look when you get a chance.

@chimosky
Copy link
Member

chimosky commented Jan 9, 2026

How come there are scripts to generate documentation, but the documentation that's supposed to be generated is missing?

Also take a look at the issue and the conversation there, you've referenced it but your PR suggests that you haven't looked at it as you've replicated something similar to an earlier attempt.

@quozl
Copy link

quozl commented Jan 9, 2026

Please stick to one pull request; there's no reason to keep opening new ones, to update a pull request all you have to do is to reset your branch and force push.

Discussion on this has been scattered across three pull requests so far. This makes it very hard for reviewers. You want it to be hard?

I see the documentation in this pull request, but I also see scripts that you had decided not to include (in #39).

@pan103769 pan103769 closed this Jan 10, 2026
@pan103769 pan103769 reopened this Jan 10, 2026
@pan103769
Copy link
Author

@quozl @chimosky Thanks for the feedback — I’ve consolidated everything into this single PR now.

This PR:

  • Adds the consolidated Sugar Activities guide (from FLOSS Manuals)
  • Removes the one-time import script and its related dependencies
  • Registers the new documentation in config

No runtime logic was changed beyond registering the new doc.

Round three , fully consolidated this time 😄
Thanks for your patience.
Please let me know if you’d like anything adjusted or split differently.

@quozl
Copy link

quozl commented Jan 10, 2026

Thanks. I've checked code examples are present, and the scripts are not.

Aggregate change includes a blank line added to requirements.txt, please don't make unnecessary changes.

Please squash your four commits into one.

Please also make sure your commit message follows Contributing - Making Commits, as at the moment the commit messages are one liners.

@pan103769 pan103769 force-pushed the add-sugar-activities-docs branch from dfab801 to 8d64dea Compare January 11, 2026 16:45
Add the consolidated Sugar Activities guide from FLOSS Manuals
(https://archive.flossmanuals.net/make-your-own-sugar-activities/)
and register it in the documentation configuration.

The content is included as-is; no content was changed or rewritten.
No runtime logic changes.
@pan103769 pan103769 force-pushed the add-sugar-activities-docs branch from 8d64dea to 189efeb Compare January 11, 2026 17:25
@pan103769
Copy link
Author

Thanks for the review!
Squashed into a single commit and removed the unnecessary blank line in requirements.txt.
No other changes made.
Please let me know if anything else is needed.

@quozl
Copy link

quozl commented Jan 12, 2026

GitHub warns me that requirements.txt now lacks a trailing newline. You could have caught this by looking at the changes in your commit.

@pan103769
Copy link
Author

Thanks for the catch, I’ve added the trailing newline to requirements.txt and pushed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants