[Fix subspacecommunity#129] Add support to pre-shared key for each client#132
Open
ssiuhk wants to merge 1 commit intosubspacecommunity:masterfrom
Open
[Fix subspacecommunity#129] Add support to pre-shared key for each client#132ssiuhk wants to merge 1 commit intosubspacecommunity:masterfrom
ssiuhk wants to merge 1 commit intosubspacecommunity:masterfrom
Conversation
…ient - Added preSharedKey generation for each config - Added keepalive setting
|
Kudos, SonarCloud Quality Gate passed!
|
|
This looks like a breaking change for existing users who would have to create a PSK to upgrade to a release containing this. Some general feedback , can you please provide some basic docs for those who would like to use this feature etc? Can you also gate it behind a flag ? |
Author
|
Sure, thanks for the feedback! Let me update it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:
Background
Added pre-shared key support to enhance security
Changes
Testing
Add a client in web interface