refactor(sdk): Clean-up tsyringe setup
#3362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes the
tsyringedependency injection setup by introducing a dedicatedsetupTsyringe.tsmodule that handles thereflect-metadataimport. This eliminates the need for scatteredimport 'reflect-metadata'statements across source and test files, making the DI configuration more maintainable and ensuring consistent initialization.Changes
packages/sdk/src/setupTsyringe.tsto centralize thereflect-metadataimportStreamrClient.ts,Config.ts,ConfigTypes.ts,PersistenceManager.ts) to import the new setup module instead ofreflect-metadatadirectlysetupTsyringe.tsto Jest'ssetupFilesAfterEnvconfiguration for automatic test initializationsetupTsyringe.tsimport tokarma-setup.jsto fix the browser test buildimport 'reflect-metadata'statements from 60+ test filesLimitations and future improvements
reflect-metadata, but could be extended in the future to include other tsyringe configuration or polyfills if needed