Skip to content

misc: Do not use "with_items" when installing packages #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vojtechtrefny merged 1 commit into from
Feb 11, 2025
Merged

misc: Do not use "with_items" when installing packages #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 42 additions & 36 deletions misc/libbytesize-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@
---
##### Fedora
- name: Install basic build tools (Fedora)
package: name={{item}} state=present
with_items:
- gcc
- make
- libtool
- autoconf
- automake
package:
state: present
name:
- gcc
- make
- libtool
- autoconf
- automake
when: ansible_distribution == 'Fedora'

- name: Install dnf-plugins-core for dnf builddep (Fedora)
Expand All @@ -22,24 +23,26 @@
when: ansible_distribution == 'Fedora'

- name: Install test dependencies (Fedora)
package: name={{item}} state=present
with_items:
- glibc-all-langpacks
- python3-polib
- python3-pocketlint
- python3-pylint
- python3-pycodestyle
package:
state: present
name:
- glibc-all-langpacks
- python3-polib
- python3-pocketlint
- python3-pylint
- python3-pycodestyle
when: ansible_distribution == 'Fedora'

##### CentOS
- name: Install basic build tools (CentOS)
package: name={{item}} state=present
with_items:
- gcc
- make
- libtool
- autoconf
- automake
package:
state: present
name:
- gcc
- make
- libtool
- autoconf
- automake
when: ansible_distribution == 'CentOS'

- name: Install dnf-plugins-core for dnf builddep (CentOS)
Expand All @@ -51,10 +54,11 @@
when: ansible_distribution == 'CentOS'

- name: Install test dependencies (CentOS)
package: name={{item}} state=present
with_items:
- glibc-all-langpacks
- python3-pip
package:
state: present
name:
- glibc-all-langpacks
- python3-pip
when: ansible_distribution == 'CentOS'

- name: Install pylint, polib, pycodestyle and pocketlint using pip (CentOS)
Expand All @@ -65,10 +69,11 @@

##### Debian/Ubuntu
- name: Install basic build tools (Debian/Ubuntu)
package: name={{item}} state=present
with_items:
- gcc
- make
package:
state: present
name:
- gcc
- make
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'

- name: Add source repositories (Debian/Ubuntu)
Expand All @@ -87,13 +92,14 @@
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'

- name: Install test dependencies (Debian/Ubuntu)
package: name={{item}} state=present
with_items:
- locales-all
- python3-polib
- python3-pip
- pycodestyle
- pylint
package:
state: present
name:
- locales-all
- python3-polib
- python3-pip
- pycodestyle
- pylint
when: ansible_distribution == 'Debian' or ansible_distribution == 'Ubuntu'

- name: Install pocketlint using pip (Debian/Ubuntu)
Expand Down