Define RODBUS_BACKUP_VERSION correctly in CMakeLists.txt

[jadamcrain]

Fixes #128

[gemini-code-assist]

Summary of Changes

Hello @jadamcrain, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #128 by updating the RODBUS_BACKUP_VERSION within the CMake configuration to "1.4.0", ensuring the project correctly integrates with the intended version of the rodbus dependency. Additionally, a minor adjustment was made to the client_example.c file, modifying the run_channel function to return an integer, which likely enhances its ability to report execution status.

Highlights

• Dependency Version Update: The RODBUS_BACKUP_VERSION in CMakeLists.txt has been updated from "1.0.0" to "1.4.0", ensuring the project fetches a newer version of the rodbus dependency.
• CMake FetchContent Enhancement: Added DOWNLOAD_EXTRACT_TIMESTAMP TRUE to the FetchContent_Declare command for rodbus in CMakeLists.txt, which can help with caching and build reproducibility.
• Example Function Signature Change: The run_channel function in client_example.c now explicitly returns an int, likely to provide status or error information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the RODBUS_BACKUP_VERSION in CMakeLists.txt and improves the build process by adding DOWNLOAD_EXTRACT_TIMESTAMP. It also fixes a missing return type in client_example.c. The changes are generally good, but I have one suggestion to improve the C example code.

[gemini-code-assist]

Adding the int return type is a good correction. To fully leverage this, you could consider using the return value to signal success or failure. The function currently always returns 0, but operations within it (like enabling the channel) could fail. Propagating such failures by returning a non-zero value would make this example more robust and a better demonstration of the API.