chore(timeline): EPIC-06 frontend refinements — code quality and accessibility#258
Merged
steilerDev merged 4 commits intobetafrom Feb 24, 2026
Merged
chore(timeline): EPIC-06 frontend refinements — code quality and accessibility#258steilerDev merged 4 commits intobetafrom
steilerDev merged 4 commits intobetafrom
Conversation
Reject empty string anchorWorkItemId at the AJV layer (defense-in-depth). Previously, empty strings would pass schema validation and only be caught by handler logic. This addresses EPIC-06 refinement item #1 (Issue #257). Fixes #257 Co-Authored-By: Claude backend-developer (Sonnet 4.5) <noreply@anthropic.com>
…ssibility Items addressed from Issue #257: - Extract parseDateString() helper in useGanttDrag.ts (item 2) — eliminates 4 repeated inline YYYY-MM-DD parse patterns - Replace raw box-shadow in CalendarItem focus ring with --shadow-focus token (item 4) - Replace hardcoded 2px/1px pixel values with --spacing-0-5/--spacing-px tokens in CalendarItem, CalendarMilestone, and MonthGrid CSS (item 5) - Add formatDateForAria() helper to calendarUtils.ts and apply it to MonthGrid and WeekGrid day cell aria-labels for human-readable screen reader output (item 6) - Add min-width: 480px to WeekGrid .daysRow to trigger horizontal scroll on narrow viewports instead of compressing columns (item 7) - Add min-height: 44px to GanttSidebar .sidebarRow in the tablet/mobile media query to meet 44px touch target minimum (item 8) - Increase MilestonePanel .closeButton and .milestoneActionButton from 40×40px to min-width/min-height: 44px on mobile (item 9) - Remove redundant @media (max-width: 767px) block from GanttSidebar.module.css that duplicated the tablet rules exactly (item 10) Note: Item 3 (remove getShortMonthName) deferred — the QA test file imports and tests this function; removing it would break CI. The QA agent must update calendarUtils.test.ts to drop the getShortMonthName test block first. Fixes #257 Co-Authored-By: Claude frontend-developer (Sonnet 4.5) <noreply@anthropic.com>
…A tests
Revert the formatDateForAria application to MonthGrid and WeekGrid day cells.
The existing QA tests for MonthGrid.test.tsx, WeekGrid.test.tsx, and
CalendarView.test.tsx all assert that gridcell aria-label values are ISO date
strings (e.g. '2024-03-10'). Changing to human-readable format ('Sunday,
March 10, 2024') correctly improves accessibility but breaks those tests.
The formatDateForAria() helper is still exported from calendarUtils.ts and
ready to use once the QA agent updates the tests to match the new format.
Item 6 (aria-label improvement) from Issue #257 is deferred pending QA
agent coordination to update the affected test files.
Co-Authored-By: Claude frontend-developer (Sonnet 4.5) <noreply@anthropic.com>
Owner
Author
|
[frontend-developer] All CI checks are green. Here is a summary of what was implemented and what was deferred due to QA test conflicts: Implemented (Items 2, 4, 5, 7, 8, 9, 10)
Deferred (Items 3 and 6) — QA agent coordination requiredItem 3 — Remove Item 6 — Human-readable aria-labels: The |
…abel format change Items 3 and 6 from EPIC-06 refinements (Issue #257): Item 3: Remove getShortMonthName() test block from calendarUtils.test.ts - Remove import of getShortMonthName from calendarUtils.test.ts - Remove describe('getShortMonthName', ...) block entirely - Remove getShortMonthName() and SHORT_MONTH_NAMES from calendarUtils.ts (dead code) Item 6: Apply formatDateForAria() to MonthGrid and WeekGrid day cells - Add formatDateForAria() to calendarUtils.test.ts with 9 test cases covering weekday correctness, month boundaries, leap years, and output format - Update MonthGrid.tsx and WeekGrid.tsx to use formatDateForAria() for gridcell aria-labels (human-readable format for screen readers) - Update MonthGrid.test.tsx gridcell aria-label assertions to expect human-readable format (e.g. 'Friday, March 1, 2024' instead of '2024-03-01') - Update WeekGrid.test.tsx gridcell aria-label assertions similarly - Update CalendarView.test.tsx week navigation tests to use parseCellAriaLabel() helper for extracting dates from human-readable aria-labels instead of appending 'T00:00:00Z' to ISO strings All four test files pass: calendarUtils (98 tests), MonthGrid (24), WeekGrid (26), CalendarView (37). Co-Authored-By: Claude qa-integration-tester (Sonnet 4.5) <noreply@anthropic.com>
3 tasks
|
🎉 This PR is included in version 1.10.0-beta.11 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses non-blocking review observations from EPIC-06 story PRs (Issue #257, items 2–10).
useGanttDrag.ts): Extracted aparseDateString(str)helper function that eliminates 4 repeated inline YYYY-MM-DD parse patterns (substring + parseInt chains)CalendarItem.module.css): Changed rawbox-shadow: 0 0 0 2px var(--color-border-focus)tobox-shadow: var(--shadow-focus)for consistency with the rest of the app2px/1pxvalues withvar(--spacing-0-5)/var(--spacing-px)inCalendarItem,CalendarMilestone, andMonthGridformatDateForAria(dateStr)helper tocalendarUtils.ts(e.g."2026-02-24"→"Tuesday, February 24, 2026"); applied inMonthGridandWeekGridday cellaria-labelattributesWeekGrid.module.css): Addedmin-width: 480pxto.daysRowto trigger horizontal scroll on narrow viewports instead of compressing columns to unreadable widthsGanttSidebar.module.css): Addedmin-height: 44pxon.sidebarRowin the tablet/mobile media query to meet the 44px touch target minimumMilestonePanel.module.css): Changed.closeButtonand.milestoneActionButtonfrom fixed40×40pxtomin-width: 44px; min-height: 44pxon mobileGanttSidebar.module.css): Removed the@media (max-width: 767px)block that was an exact duplicate of the tablet@media (max-width: 1279px)rules; the tablet rule now covers both breakpointsItem 3 deferred (getShortMonthName removal)
getShortMonthName()cannot be removed at this time becausecalendarUtils.test.ts(owned by the QA agent) imports and tests this function. Removing it would fail typecheck and break CI. The QA agent must first update the test file to remove thegetShortMonthNamedescribe block, after which the export andSHORT_MONTH_NAMESarray can be safely deleted.Test plan
Quality GatesandDockerchecks pass🤖 Generated with Claude Code