Add from_string classmethod constructor for CmdStanModel #849
+42
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
This implements a basic version of instantiating a CmdStanModel from a code string. For discussion, see #757; this implements option 3 from that discussion. I've implemented the classmethod itself as well as a (basic) unit test. I've ensured code passes both flake8 and pylint.
This is a first draft, feel free to reject this pull request, to request changes, or to completely ignore 👍 I don't want to overload you as maintainers!
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Erik-Jan van Kesteren
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: