-
Notifications
You must be signed in to change notification settings - Fork 8
Chore/prometheus #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/prometheus #25
Conversation
- added 2 targets to Makefile to control prometheus/cadvisor
…ometheus * commit '90ef0fda09876db473bcd33cad5a422976227efe': Adding prometheus compose to track system resources during netowrk test - added 2 targets to Makefile to control prometheus/cadvisor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left only one question, but approving up-front since I already tested the functionality locally multiple times.
|
let's hold off on merging this - i realized we need to add the linter check for this new compose file (of which there are some warnings being thrown locally). i'll fix and add a commit to address before merging |
BowTiedRadone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a prometheus/cadvisor component to hacknet for tracking metrics on the hacknet services.
default
upwill not run this, and is optional:make up-promwill start prometheus api and cadvisor servicesmake down-promwill bring down the prom and cadvisor services.note, there is a warning due to piggybacking on the existing network name.