Fix OAuth token refresh context cancellation #3539
Open
+70
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TokenSource created in processToken() was using the OAuth flow's startup context, which gets cancelled when the callback server shuts down. When the access token expires (~1 hour later) and refresh is attempted, the HTTP request fails with "context canceled". This triggers a full re-authentication flow with new DCR client registration, requiring user interaction in the browser. The fix uses context.Background() for the TokenSource, since it is long-lived and must remain valid for token refresh operations long after the OAuth flow completes. Closes stacklokgh-3538 Signed-off-by: Greg Katz <gkatz@indeed.com>
gkatz2
requested review from
ChrisJBurns,
JAORMX,
dmjb,
jhrozek and
yrobla
as code owners
amirejaz
previously approved these changes
Jan 30, 2026
Contributor
|
@gkatz2 There is a linter error which needs to be fixed. 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 65.34% 65.34%
=======================================
Files 403 403
Lines 39278 39278
=======================================
Hits 25665 25665
Misses 11628 11628
Partials 1985 1985 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix OAuth token refresh failure that occurs when the access token expires (~1 hour), requiring users to manually reauthenticate in the browser.
Problem
The
TokenSourcecreated inprocessToken()was using the OAuth flow's startup context, which gets cancelled when the callback server shuts down after authentication completes. When the token expires and refresh is attempted, the HTTP request fails with "context canceled".This triggers a full re-authentication flow with new DCR client registration, requiring user interaction.
Solution
Use
context.Background()for theTokenSourceinstead of the OAuth flow's context, since theTokenSourceis long-lived and must remain valid for token refresh operations long after the OAuth flow completes.Testing
TestTokenRefreshAfterContextCancellationunit test that:Related
Closes #3538
Complements #3418 (DCR credential persistence) - that fix handles restarts, this fix handles runtime token refresh.