Add E2E tests for secrets management #3485
Merged
+474
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 65.35% 65.36% +0.01%
==========================================
Files 403 403
Lines 39210 39210
==========================================
+ Hits 25625 25631 +6
+ Misses 11599 11591 -8
- Partials 1986 1988 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmjb
force-pushed
the
api-e2e-phase-viii
branch
2 times, most recently
from
a910ab4 to
4da9af4
Compare
github-actions
bot
added
size/M
dmjb
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
eleftherias,
jhrozek,
lujunsan,
rdimitrov and
yrobla
as code owners
eleftherias
reviewed
Jan 28, 2026
Member
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
The 404 tests are failing with a 405. Also added one question inline.
dmjb
changed the title
github-actions
bot
added
size/M
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
8de7cb0 to
7b47971
Compare
github-actions
bot
added
size/M
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
7b47971 to
4253787
Compare
github-actions
bot
added
size/M
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
4253787 to
d5f9b1b
Compare
github-actions
bot
added
size/M
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
2f65d9d to
92a793a
Compare
github-actions
bot
added
size/M
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
f61a69a to
641fa28
Compare
dmjb
changed the title
github-actions
bot
added
size/M
eleftherias
reviewed
Jan 30, 2026
dmjb
force-pushed
the
api-e2e-phase-viii
branch
from
5126c53 to
8d85a4f
Compare
github-actions
bot
added
size/M
eleftherias
approved these changes
Jan 30, 2026
lujunsan
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to dependency issues (keychain for encrypted, or 1password), these tests only test the environment type. This does not cover all secrets management functionality, but verifies basic correctness of the secrets endpoints.